Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add ntp_settings #3293

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add ntp_settings

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

ntp_settings:
  server_vrf: <str>
  servers:
    - name: <str>
      burst: <bool>
      iburst: <bool>
      key: <int>
      maxpoll: <int>
      minpoll: <int>
      version: <int>
  authenticate: <bool>
  authenticate_servers_only: <bool>
  authentication_keys:
    - id: <int>
      hash_algorithm: <str>
      key: <str>
      key_type: <str>
  trusted_keys: <str>

How to test

  • Added molecule test
  • Updated existing molecule scenarios and examples which were using the eos_cli_config_gen model.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Oct 24, 2023
@pvinci-arista
Copy link
Contributor

Should we add a key for something like ntp_serve_all: <bool>?

@ClausHolbechArista
Copy link
Contributor Author

Should we add a key for something like ntp_serve_all: <bool>?

This is for eos_designs, and I mapped everything from eos_cli_config_gen. Once we get more features in, we can add them here as well.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft November 8, 2023 12:14
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review November 10, 2023 14:11
@carlbuchmann carlbuchmann self-requested a review November 10, 2023 14:12
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@philippebureau philippebureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested
LGTM

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 14, 2023
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit e92d230 into aristanetworks:devel Dec 14, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - Improve Campus Support rn: Feat(eos_designs) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants