Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Adding application traffic recognition model #3350

Merged
merged 25 commits into from
Dec 14, 2023
Merged

Feat(eos_cli_config_gen): Adding application traffic recognition model #3350

merged 25 commits into from
Dec 14, 2023

Conversation

amitsagar-arsita
Copy link
Contributor

@amitsagar-arsita amitsagar-arsita commented Nov 15, 2023 •
edited by gmuloc
Loading

Change Summary

Adding application traffic recognition support.

Have updated the cli model and the template code to support application traffic recognition related configs.
Yet to update the test files.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added cli model for application traffic recognition
It involves creating user define Ipv4 appplications, creating and modifying categories,
creating application profiles( which is mapped to avt in load balance policy ).
Application profiles allows to groups application, application and services, transport protocol,
and category and service ( which are mainly applicable for DPI applications )

How to test

Tested using molecule.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Nov 15, 2023
@gmuloc gmuloc changed the title Feat(eos-cli-config-gen): Adding application traffic recognition model Feat(eos_cli_config_gen): Adding application traffic recognition model Nov 16, 2023
@carlbuchmann carlbuchmann marked this pull request as draft November 17, 2023 02:46
@carlbuchmann
Copy link
Member

converting to draft as this still requires lots of work!

@github-actions github-actions bot added role: eos_validate_state state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Nov 17, 2023
@github-actions github-actions bot added type: documentation Improvements or additions to documentation type: dependencies Pull requests that update a dependency file role: build_output_folders issue related to build_output_folders role role: cvp_configlet_upload issue related to cvp_configlet_upload role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: dhcp_provisioner labels Nov 17, 2023
gmuloc
gmuloc reviewed Nov 23, 2023
View reviewed changes
.../arista/avd/molecule/eos_cli_config_gen/intended/configs/application-traffic-recognition.cfg Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Show resolved Hide resolved
...ista/avd/roles/eos_cli_config_gen/templates/documentation/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
...ista/avd/roles/eos_cli_config_gen/templates/documentation/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
...ista/avd/roles/eos_cli_config_gen/templates/documentation/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos-intended-config.j2 Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/templates/eos/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
gmuloc
gmuloc reviewed Dec 7, 2023
View reviewed changes
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Show resolved Hide resolved
...ista/avd/roles/eos_cli_config_gen/templates/documentation/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/templates/eos/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/templates/eos/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
...ections/arista/avd/roles/eos_cli_config_gen/templates/eos/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
@gmuloc gmuloc requested review from gmuloc and a team December 7, 2023 12:14
@gmuloc gmuloc marked this pull request as ready for review December 7, 2023 12:15
ClausHolbechArista
ClausHolbechArista reviewed Dec 7, 2023
View reviewed changes
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/application-traffic-recognition.md Outdated Show resolved Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/application-traffic-recognition.md Show resolved Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/application-traffic-recognition.md Outdated Show resolved Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/application-traffic-recognition.md Outdated Show resolved Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/application-traffic-recognition.md Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...roles/eos_cli_config_gen/schemas/schema_fragments/application_traffic_recognition.schema.yml Outdated Show resolved Hide resolved
...ista/avd/roles/eos_cli_config_gen/templates/documentation/application-traffic-recognition.j2 Outdated Show resolved Hide resolved
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Dec 11, 2023
@gmuloc gmuloc requested a review from a team December 11, 2023 12:22
@gmuloc gmuloc merged commit 94611cf into aristanetworks:devel Dec 14, 2023
41 checks passed
@gmuloc gmuloc removed the one approval This PR has one approval and is only missing one more. label Dec 14, 2023
@gmuloc gmuloc mentioned this pull request Dec 19, 2023
Merged
4 tasks
@amitsagar-arsita amitsagar-arsita deleted the application_traffic_recognition branch January 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@amitsagar-arsita amitsagar-arsita

Labels
EPIC - AVD AutoVPN/WAN rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amitsagar-arsita @carlbuchmann @gmuloc @ClausHolbechArista @carl-baillargeon @arista-matt @pmprado @chetryan