-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add other CCS (Campus) platforms for PoE support #3374
Merged
carlbuchmann
merged 6 commits into
aristanetworks:devel
from
jonxstill:poe_platform_rules
Dec 21, 2023
Merged
Feat(eos_designs): Add other CCS (Campus) platforms for PoE support #3374
carlbuchmann
merged 6 commits into
aristanetworks:devel
from
jonxstill:poe_platform_rules
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonxstill
force-pushed
the
poe_platform_rules
branch
from
December 6, 2023 13:51
4fe2c4b
to
5e6d4b8
Compare
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/platform.py
Outdated
Show resolved
Hide resolved
jonxstill
force-pushed
the
poe_platform_rules
branch
from
December 14, 2023 11:49
5e6d4b8
to
9891907
Compare
ClausHolbechArista
approved these changes
Dec 15, 2023
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Dec 15, 2023
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/platform.py
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_designs/schemas/schema_fragments/platform_settings.schema.yml
Outdated
Show resolved
Hide resolved
jonxstill
commented
Dec 21, 2023
ansible_collections/arista/avd/plugins/plugin_utils/eos_designs_shared_utils/platform.py
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_designs/schemas/schema_fragments/platform_settings.schema.yml
Outdated
Show resolved
Hide resolved
carlbuchmann
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
EPIC - Improve Campus Support
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_designs)
role: eos_designs
issue related to eos_designs role
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add other CCS (Campus) platforms to DEFAULT_PLATFORM_SETTINGS.
Additionally, moved 722XP to a platform_settings entry without
trident_forwarding_table_partition
as this isn't supported on TD3x1 or TD3x2.An additional fix changes the
trident_forwarding_table_partition
values for the 720XP so the switch will actually take these values.Component(s) name
arista.avd.eos_designs
Proposed changes
How to test
N/A
Checklist
Repository Checklist