Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): Fix radius attribute 32 format option. #3413

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Fix(eos_cli_config_gen): Fix radius attribute 32 format option. #3413

merged 3 commits into from
Dec 14, 2023

Conversation

Chr1stophP
Copy link
Contributor

@Chr1stophP Chr1stophP commented Dec 8, 2023 •
edited by carlbuchmann
Loading

Change Summary

Fix radius attribute 32 format option.

Related Issue(s)

Fixes #3412

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fixed templates.

How to test

Added test case.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Chr1stophP Chr1stophP requested review from a team as code owners December 8, 2023 10:48
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Dec 8, 2023
@gmuloc gmuloc changed the title Bug(eos_cli_gen): Fix for PR3412 Radius attribute attribute_32_includ… Fix(eos_cli_config_gen): Fix for PR3412 Radius attribute attribute_32_include_in_access_req Dec 8, 2023
@carlbuchmann carlbuchmann added this to the v4.5.0 milestone Dec 11, 2023
@carlbuchmann
Copy link
Member

@Chr1stophP - moving to draft since the PR is missing new unit tests. I'm happy to help you on a Zoom call to complete it!

@carlbuchmann carlbuchmann marked this pull request as draft December 11, 2023 13:55
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 14, 2023
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review December 14, 2023 11:49
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Fix for PR3412 Radius attribute attribute_32_include_in_access_req Fix(eos_cli_config_gen): Fix radius attribute 32 format option. Dec 14, 2023
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Dec 14, 2023
carlbuchmann
carlbuchmann approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit f82858f into aristanetworks:devel Dec 14, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@Chr1stophP Chr1stophP

Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.

Radius attribute attribute_32_include_in_access_req
3 participants
@Chr1stophP @carlbuchmann @ClausHolbechArista