Feat(eos_cli_config_gen): Add TTL max hops in router bgp #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
32 tasks
|
it works for router_bgp / neighbors It is not working for router_bgp / peer_groups I am getting an error about missing ''ip_address'' attribute i can see the key being added to the structured config properly
|
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
|
see comment above for proposed fix that works for me |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
added 6 commits
January 5, 2024 15:19
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
added
the
one approval
|
This one needs an update of all molecule scenarios: cd ansible_collections/arista/avd/molecule
make refresh-facts |
ClausHolbechArista
removed
the
one approval
gmuloc
reviewed
Jan 11, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/router-bgp.j2
Outdated
Show resolved
Hide resolved
gmuloc
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Support TTL max hops at the peer group and neighbor level
Related Issue(s)
Fixes #3424
Component(s) name
eos_cli_config_genProposed changes
CF
How to test
Molecule
Checklist
Repository Checklist