Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Empty description under network-ports #3445

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Dec 18, 2023

Change Summary

Strip empty strings from the rendered structured_config for ethernet_interfaces for connected_endpoints

Related Issue(s)

Fixes #3443

Component(s) name

arista.avd.eos_designs

Proposed changes

Replacing the default tuple for strip_null_fom_data with (None, "").
Apply same fix for port-channels where the issue can also be reproduced

How to test

molecule (first commit shows the issue)

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners December 18, 2023 22:44
@gmuloc gmuloc added this to the v4.6.0-dev1 milestone Dec 18, 2023
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Dec 18, 2023
@gmuloc gmuloc added type: bug Something isn't working and removed state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Dec 18, 2023
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Dec 18, 2023
Copy link
Contributor

@bjmeuer bjmeuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with:

network_ports:
  - switches:
      - dee-lf93101[a,b]
    switch_ports:
      - Ethernet1-24/1-4

works fine for me

@ClausHolbechArista ClausHolbechArista merged commit 62905fc into aristanetworks:devel Dec 19, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty "description" under each ports in intended configs
3 participants