Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI(pyavd): Ignore Jinja generated instructions from coverage #3451

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Dec 19, 2023

Change Summary

Ignore Jinja2 instructions from coverage report.
Leveraging this: https://coverage.readthedocs.io/en/latest/excluding.html#advanced-exclusion
sadly cannot exclude multilines

Component(s) name

pyavd

Proposed changes

Added list of exceptions from what Jinja code is generated

How to test

Let pipeline execute

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners December 19, 2023 15:41
@gmuloc gmuloc changed the title CI: Ignore Jinja generated instructions from coverage CI(pyavd): Ignore Jinja generated instructions from coverage Dec 19, 2023
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python-avd/pyproject.toml Outdated Show resolved Hide resolved
python-avd/pyproject.toml Outdated Show resolved Hide resolved
python-avd/tox.ini Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista merged commit 0f73e76 into aristanetworks:devel Dec 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants