Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_validate_state): ANTA Fix bug when skipping specific tests of AvdTestBGP #3498

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

carl-baillargeon
Copy link
Contributor

Change Summary

Fix bug when skipping specific tests of AvdTestBGP.

Related Issue(s)

Fixes #3497

Component(s) name

arista.avd.eos_validate_state ANTA

Proposed changes

  • Change the test_definition of AvdTestBGP to return a proper dictionary with ANTA module as keys and list of ANTA tests as values (like the other tests)
  • Add logging for skipped tests

How to test

Run validate state in ANTA mode with the following input variable:

skipped_tests:
  - category: AvdTestBGP
    tests:
      - VerifyRoutingProtocolModel

OR

skipped_tests:
  - category: AvdTestBGP
    tests:
      - VerifyBGPSpecificPeers

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team January 15, 2024 20:46
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jan 15, 2024
@gmuloc gmuloc merged commit 38237ed into aristanetworks:devel Jan 15, 2024
37 checks passed
@carlbuchmann carlbuchmann removed the one approval This PR has one approval and is only missing one more. label Feb 1, 2024
@carl-baillargeon carl-baillargeon deleted the fix/bgp-skipped-tests branch May 18, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_validate_state): ANTA AttributeError when skipping specific tests of AvdTestBGP
4 participants