-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Enforce unicity of region IDs and per-region site IDs for CV Pathfinder #4121
Feat(eos_designs): Enforce unicity of region IDs and per-region site IDs for CV Pathfinder #4121
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4121
# Activate the virtual environment
source test-avd-pr-4121/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@unique-id-regions-and-sites#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,unique-id-regions-and-sites --force
# Optional: Install AVD examples
cd test-avd-pr-4121
ansible-playbook arista.avd.install_examples |
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/cv_pathfinder_regions.schema.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…IDs for CV Pathfinder
79b408e
to
7de4031
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality testing successful.
I don't see any documentation being updated, and I would have expected to see -> id: <int; 1-10000; required; unique>
This is captured in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested in lab!
Change Summary
Leverage
unique_keys
introduced in #3725 as plannedComponent(s) name
arista.avd.eos_designs
Proposed changes
CF schema fragment changes
How to test
Tested locally by triggering conflicting scenario (
unique_keys
work as expected)Checklist
Repository Checklist