Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.snmp_hash to PyAVD #4136

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 19, 2024

Change Summary

Move jinja filter code for arista.avd.snmp_hash to PyAVD

Component(s) name

arista.avd.snmp_hash

Proposed changes

  • Move filter code and update references
  • Move unit test to pyavd pytest

How to test

pytest, molecule.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4136
# Activate the virtual environment
source test-avd-pr-4136/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/plugins/Move-filter-snmp_hash-to-PyAVD#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/plugins/Move-filter-snmp_hash-to-PyAVD --force
# Optional: Install AVD examples
cd test-avd-pr-4136
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista changed the title Refactor(plugins): Move filter snmp_hash to PyAVD Refactor(plugins): Move jinja filter code for arista.avd.snmp_hash to PyAVD Jun 19, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 19, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/plugins/Move-filter-snmp_hash-to-PyAVD branch from fa4e86c to e620b4c Compare June 19, 2024 17:01
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 19, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review June 19, 2024 17:01
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 19, 2024 17:01
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit faa4684 into aristanetworks:devel Jun 19, 2024
43 checks passed
@ClausHolbechArista ClausHolbechArista deleted the refactor/plugins/Move-filter-snmp_hash-to-PyAVD branch June 21, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants