-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move jinja filter code for arista.avd.range_expand to PyAVD #4138
Merged
ClausHolbechArista
merged 11 commits into
aristanetworks:devel
from
laxmikantchintakindi:range_expand
Jun 21, 2024
Merged
Refactor(plugins): Move jinja filter code for arista.avd.range_expand to PyAVD #4138
ClausHolbechArista
merged 11 commits into
aristanetworks:devel
from
laxmikantchintakindi:range_expand
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4138
# Activate the virtual environment
source test-avd-pr-4138/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@range_expand#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,range_expand --force
# Optional: Install AVD examples
cd test-avd-pr-4138
ansible-playbook arista.avd.install_examples |
laxmikantchintakindi
force-pushed
the
range_expand
branch
3 times, most recently
from
June 20, 2024 07:51
f3f7d0b
to
07981a4
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
force-pushed
the
range_expand
branch
2 times, most recently
from
June 20, 2024 11:02
56543ef
to
0bf6848
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
laxmikantchintakindi
force-pushed
the
range_expand
branch
from
June 20, 2024 11:06
0bf6848
to
29de7cf
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
laxmikantchintakindi
force-pushed
the
range_expand
branch
from
June 20, 2024 11:10
29de7cf
to
5ea0fbb
Compare
MaheshGSLAB
reviewed
Jun 20, 2024
gmuloc
approved these changes
Jun 20, 2024
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Jun 20, 2024
MaheshGSLAB
approved these changes
Jun 20, 2024
ClausHolbechArista
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(plugins)
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for arista.avd.range_expand to PyAVD
Related Issue(s)
Fixes #4137
Component(s) name
arista.avd.range_expand
Proposed changes
Moving the code and unit tests for arista.avd.range_expand filter to PyAVD
How to test
Checklist
User Checklist
Repository Checklist