Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.range_expand to PyAVD #4138

Merged

Conversation

laxmikantchintakindi
Copy link
Contributor

Change Summary

Move jinja filter code for arista.avd.range_expand to PyAVD

Related Issue(s)

Fixes #4137

Component(s) name

arista.avd.range_expand

Proposed changes

Moving the code and unit tests for arista.avd.range_expand filter to PyAVD

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4138
# Activate the virtual environment
source test-avd-pr-4138/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@range_expand#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,range_expand --force
# Optional: Install AVD examples
cd test-avd-pr-4138
ansible-playbook arista.avd.install_examples

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 20, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@laxmikantchintakindi laxmikantchintakindi force-pushed the range_expand branch 2 times, most recently from 56543ef to 0bf6848 Compare June 20, 2024 11:02
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 20, 2024 12:25
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners June 20, 2024 12:25
@MaheshGSLAB MaheshGSLAB requested a review from a team June 20, 2024 12:26
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 20, 2024
@ClausHolbechArista ClausHolbechArista merged commit f95b5e9 into aristanetworks:devel Jun 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins) type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor(plugins): Move jinja filter code for arista.avd.range_expand to PyAVD
4 participants