Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move internal cv_client code to PyAVD #4141

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Move internal cv_client code to PyAVD

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4141
# Activate the virtual environment
source test-avd-pr-4141/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/plugins/move-cv-client-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/plugins/move-cv-client-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4141
ansible-playbook arista.avd.install_examples

python-avd/pyproject.toml Outdated Show resolved Hide resolved
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review June 20, 2024 13:51
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 20, 2024 13:51
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once error message is changed to remove mention to pip as we discuessed and CI passes.

@ClausHolbechArista ClausHolbechArista merged commit becc92f into aristanetworks:devel Jun 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants