-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move internal cv_client code to PyAVD #4141
Merged
ClausHolbechArista
merged 14 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/plugins/move-cv-client-to-pyavd
Jun 21, 2024
Merged
Refactor(plugins): Move internal cv_client code to PyAVD #4141
ClausHolbechArista
merged 14 commits into
aristanetworks:devel
from
ClausHolbechArista:refactor/plugins/move-cv-client-to-pyavd
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…factor/plugins/move-cv-client-to-pyavd
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4141
# Activate the virtual environment
source test-avd-pr-4141/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/plugins/move-cv-client-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/plugins/move-cv-client-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4141
ansible-playbook arista.avd.install_examples |
gmuloc
reviewed
Jun 20, 2024
gmuloc
reviewed
Jun 21, 2024
gmuloc
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once error message is changed to remove mention to pip
as we discuessed and CI passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move internal cv_client code to PyAVD
Checklist
User Checklist
Repository Checklist