Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.status_render to PyAVD #4142

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jun 20, 2024

Change Summary

Move jinja filter code for arista.avd.status_render to PyAVD

Related Issue(s)

Fixes #

Component(s) name

Filter

  • arista.avd.status_render

Proposed changes

Move jinja filter code and tests for arista.avd.status_render to PyAVD

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4142
# Activate the virtual environment
source test-avd-pr-4142/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@markdown_rendering#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,markdown_rendering --force
# Optional: Install AVD examples
cd test-avd-pr-4142
ansible-playbook arista.avd.install_examples

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR looks wrong :)

@Shivani-gslab Shivani-gslab changed the title Refactor(plugins): Move jinja filter code for arista.avd.generate_lacp_id to PyAVD Refactor(plugins): Move jinja filter code for arista.avd.status_render to PyAVD Jun 20, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review June 20, 2024 11:31
@Shivani-gslab Shivani-gslab requested review from a team as code owners June 20, 2024 11:31
@ClausHolbechArista ClausHolbechArista requested a review from a team June 20, 2024 11:41
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 20, 2024
@gmuloc gmuloc merged commit 5d6858b into aristanetworks:devel Jun 20, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins) type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants