Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication under port-channel-interfaces #4353

Open
wants to merge 13 commits into
base: devel
Choose a base branch
from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 13, 2024

Change Summary

Add support for additional modes and feature in isis authentication.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add support for additional modes and feature in isis authentication.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4353
# Activate the virtual environment
source test-avd-pr-4353/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/port_channel_interfaces/isis_auth#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/port_channel_interfaces/isis_auth --force
# Optional: Install AVD examples
cd test-avd-pr-4353
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Aug 13, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication. Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication Aug 13, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication Feat(eos_cli_config_gen): Add support for additional modes and feature in isis authentication under port-channel-interfaces Aug 13, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/port_channel_interfaces/isis_auth branch 2 times, most recently from d7ad356 to 4fed31c Compare August 21, 2024 04:23
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review August 21, 2024 05:00
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 23, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/port_channel_interfaces/isis_auth branch from e5b0e2d to 3114aec Compare September 9, 2024 15:26
Copy link

github-actions bot commented Sep 9, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Sep 9, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/port_channel_interfaces/isis_auth branch from 3114aec to 6451e3e Compare September 9, 2024 15:31
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/port_channel_interfaces/isis_auth branch from 58b0e77 to 4f9bebe Compare September 21, 2024 06:25
Copy link

sonarcloud bot commented Oct 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant