Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: New node type keys for m&e devices #4485

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
+33 −1
Draft

Feat: New node type keys for m&e devices #4485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 33 additions & 1 deletion python-avd/pyavd/_eos_designs/shared_utils/node_type_keys.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@
"uplink_type": "port-channel",
},
]

# NOTE: There is a static list of default node_type_keys in the fabric documentation templates which must be updated as well

DEFAULT_NODE_TYPE_KEYS = {
Expand Down Expand Up @@ -174,6 +173,39 @@
"l3": True,
},
},
{
"key": "ptp_leaf",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be prefixed with media_ as well?

Copy link

@sarunac sarunac Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be okay to leave the media_ so non-media PTP customers can consume it too ?

"type": "ptp_leaf",
"connected_endpoints": True,
"network_services": {
"l2": True,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need L2 on all device types? Do you have a design I can look at?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes PTP distribution leafs can also have l2 connected endpoints . Slide 13 here is an example where PTP leaf is also a media_leaf which has connected endpoints which can be a mix of both L2 and/or L3. https://docs.google.com/presentation/d/1XyV6eMJpGsNNP9bxZaxJ25e2VBK96W2rOyHbwZgKanw/edit#slide=id.g1a2c972f82e_0_204

"l3": True,
},
"default_overlay_routing_protocol": "none",
"default_ptp_priority1": 10,
},
{
"key": "media_spine",
"type": "media_spine",
"connected_endpoints": True,
"network_services": {
"l2": True,
"l3": True,
},
"default_overlay_routing_protocol": "none",
"default_ptp_priority1": 20,
},
{
"key": "media_leaf",
"type": "media_leaf",
"connected_endpoints": True,
"network_services": {
"l2": True,
"l3": True,
},
"default_overlay_routing_protocol": "none",
"default_ptp_priority1": 30,
},
# Avoiding duplicate code
*MPLS_DEFAULT_NODE_TYPE_KEYS,
],
Expand Down