-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Exclude l3_edge neighbors from peer_group #4491
base: devel
Are you sure you want to change the base?
Feat(eos_designs): Exclude l3_edge neighbors from peer_group #4491
Conversation
…erlay" is set to False and the protocol is ebgp.
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4491
# Activate the virtual environment
source test-avd-pr-4491/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/nathanmusser/avd.git@issue4379_p2p_links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/nathanmusser/avd.git#/ansible_collections/arista/avd/,issue4379_p2p_links --force
# Optional: Install AVD examples
cd test-avd-pr-4491
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the description for the routing_protocol
key in the schema fragment to explain the new behavior.
Also please add a test in molecule for this scenario. It should be enough to add another interface to one of the existing tests. I suggest
|
Quality Gate passedIssues Measures |
Change Summary
When
routing_protocol
is set toebgp
andinclude_in_underlay_protocol
is set tofalse
for anl3_edge
link, previously it was not rendered in BGP. It is now rendered into BGP without using the default underlay peer group.Related Issue(s)
Partially fixes #4379
Component(s) name
arista.avd.eos_designs
Proposed changes
Only render the peer group if
include_in_underlay_protocol
is set totrue
.How to test
Using the dual-dc-l3ls example topology you can modify the
l3_edge
include_in_underlay_protocol
androuting_protocol
values in theFABRIC.yml
group_var.Checklist
User Checklist
Repository Checklist
Additional
I can add tests for this to molecule. I'm not sure if what the scope of the molecule tests are for the AVD project, and if we want every edge case covered or not. Additionally, while this behavior feels intuitive to me, I can explicitly add an example to the documentation, but documenting an edge case like this could be considered clutter so I didn't add anything yet.