Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs)!: Change default VRF Diagnostic Loopback descriptions #4534

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Oct 1, 2024

Change Summary

Change default VRF Diagnostic Loopback descriptions

Change Summary

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Adding new default descriptions for VRF Diagnostic loopbacks
  • Add templating support for all descriptions (both default and override)
  • Add key with default template: default_vrf_diag_loopback_description
  • Updated porting guide

How to test

  • Update molecule scenarios and examples
  • Verified no changes for scenarios with custom description logic in unit tests

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Oct 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4534
# Activate the virtual environment
source test-avd-pr-4534/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/diag-loopback-description#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/diag-loopback-description --force
# Optional: Install AVD examples
cd test-avd-pr-4534
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 1, 2024
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 1, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/diag-loopback-description branch from e7ccccc to 2e78278 Compare October 2, 2024 06:28
@github-actions github-actions bot removed the state: conflict PR with conflict label Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review October 2, 2024 08:23
Copy link

sonarcloud bot commented Oct 2, 2024

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc requested a review from a team October 2, 2024 13:27
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Oct 2, 2024
@gmuloc gmuloc requested a review from a team October 2, 2024 13:27
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested in lab and reverting to 4.x syntax

@carlbuchmann carlbuchmann merged commit 5de2b52 into aristanetworks:devel Oct 2, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants