-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs)!: Change default VRF Diagnostic Loopback descriptions #4534
Refactor(eos_designs)!: Change default VRF Diagnostic Loopback descriptions #4534
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4534
# Activate the virtual environment
source test-avd-pr-4534/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/diag-loopback-description#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/diag-loopback-description --force
# Optional: Install AVD examples
cd test-avd-pr-4534
ansible-playbook arista.avd.install_examples |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
e7ccccc
to
2e78278
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested in lab and reverting to 4.x syntax
Change Summary
Change default VRF Diagnostic Loopback descriptions
Change Summary
Component(s) name
arista.avd.eos_designs
Proposed changes
default_vrf_diag_loopback_description
How to test
Checklist
User Checklist
Repository Checklist