Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_validate_state): Add validation for BGP IPv4 peers in VRFs #4538

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

carl-baillargeon
Copy link
Contributor

Change Summary

AvdTestBGP now checks for BGP IPv4 peers in all VRFs.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_validate_state

Proposed changes

How to test

  • Add BGP peers in a VRF under network services
  • Run eos_designs + eos_validate_state

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carl-baillargeon carl-baillargeon requested review from a team as code owners October 1, 2024 15:48
Copy link

github-actions bot commented Oct 1, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4538
# Activate the virtual environment
source test-avd-pr-4538/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@feat/bgp_vrf_peers_validation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,feat/bgp_vrf_peers_validation --force
# Optional: Install AVD examples
cd test-avd-pr-4538
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Oct 1, 2024

@philippebureau philippebureau self-requested a review October 1, 2024 18:57
Copy link
Contributor

@philippebureau philippebureau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested with lab and customer repo

@github-actions github-actions bot added the state: conflict PR with conflict label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done as a separate test id, so we can disable it and have it mentioned in the porting guide how to disable it. It will add thousands of tests for scaled customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants