-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_validate_state): Add validation for BGP IPv4 peers in VRFs #4538
base: devel
Are you sure you want to change the base?
Feat(eos_validate_state): Add validation for BGP IPv4 peers in VRFs #4538
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4538
# Activate the virtual environment
source test-avd-pr-4538/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@feat/bgp_vrf_peers_validation#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,feat/bgp_vrf_peers_validation --force
# Optional: Install AVD examples
cd test-avd-pr-4538
ansible-playbook arista.avd.install_examples |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with lab and customer repo
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be done as a separate test id, so we can disable it and have it mentioned in the porting guide how to disable it. It will add thousands of tests for scaled customers.
Change Summary
AvdTestBGP
now checks for BGP IPv4 peers in all VRFs.Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_validate_state
Proposed changes
How to test
Checklist
User Checklist
Repository Checklist