Feat(eos_cli_config_gen): Add support for `monitor server radius` #4595

laxmikantchintakindi · 2024-10-15T15:24:36Z

Change Summary

Add support for monitor server radius in eos_cli_config_gen.

monitor_server_radius:
  service_dot1x: <bool>
  probe:
    interval: <int, 1-1000>
    threshold_failure: <int, 1-255>
    method: <str; "status-server" | "access-request">
    access_request: # Only relevant when method is 'access-request'
      username: <str>
      password: <str> # Password as type 7

Related Issue(s)

Fixes #4273

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add support for monitor server radius in eos_cli_config_gen.

monitor_server_radius:
  service_dot1x: <bool>
  probe:
    interval: <int, 1-1000>
    threshold_failure: <int, 1-255>
    method: <str; "status-server" | "access-request">
    access_request: # Only relevant when method is 'access-request'
      username: <str>
      password: <str> # Password as type 7

How to test

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions · 2024-10-15T15:24:49Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4595
# Activate the virtual environment
source test-avd-pr-4595/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/monitor-server-radius#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/monitor-server-radius --force
# Optional: Install AVD examples
cd test-avd-pr-4595
ansible-playbook arista.avd.install_examples

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_server_radius.schema.yml

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-server-radius.j2

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos-intended-config.j2

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-server-radius.j2

ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/monitor-server-radius.md

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-server-radius.j2

alexeygorbunov · 2024-10-30T19:39:00Z

python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/monitor-server-radius.j2

+| Threshold failure | {{ monitor_server_radius.probe.threshold_failure }} |
+{%         endif %}
+{%         if monitor_server_radius.probe.method is arista.avd.defined %}
+| Probe method | {{ monitor_server_radius.probe.method }} |


Would it make sense to expose username (not sure about password) in case we use method: access-request?

alexeygorbunov · 2024-11-05T00:52:54Z

...ctions/arista/avd/molecule/eos_cli_config_gen/documentation/devices/monitor-server-radius.md

Is this file needed? There is no inventory host with such name

nope it should be removed

gmuloc · 2024-11-04T10:03:51Z

...ions/arista/avd/molecule/eos_cli_config_gen/documentation/devices/monitor-server-radius-1.md

+   service dot1x
+   probe interval 100 seconds
+   probe threshold failure 100
+   probe method access-request username arista password 7 141600021F102B


please make sure this is removed from documentation by default using hide_password

gmuloc · 2024-11-04T10:04:30Z

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-server-radius.j2

+{%         if monitor_server_radius.probe.access_request.username is arista.avd.defined and
+              monitor_server_radius.probe.access_request.password is arista.avd.defined %}
+{%             set access_request = monitor_server_radius.probe.access_request %}
+   probe method access-request username {{ access_request.username }} password {{ access_request.password_type | arista.avd.default("7") }} {{ access_request.password }}


Suggested change

probe method access-request username {{ access_request.username }} password {{ access_request.password_type | arista.avd.default("7") }} {{ access_request.password }}

probe method access-request username {{ access_request.username }} password {{ access_request.password_type | arista.avd.default("7") }} {{ access_request.password | arista.avd.hide_passwords(hide_passwords }}

gmuloc · 2024-11-05T14:20:39Z

...ctions/arista/avd/molecule/eos_cli_config_gen/documentation/devices/monitor-server-radius.md

nope it should be removed

ClausHolbechArista · 2024-11-06T09:58:09Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_server_radius.schema.yml

+                required: true
+              password:
+                type: str
+                description: Type 7 password.


It is not a type-7 password if you select something else in password_type. Please look in other data models for inspiration for a better description.

Removed the description.

ClausHolbechArista · 2024-11-06T10:00:06Z

python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_server_radius.schema.yml

+        keys:
+          interval:
+            type: int
+            description: Server probe period in seconds.


Suggested change

description: Server probe period in seconds.

description: Server probe interval in seconds.

ClausHolbechArista · 2024-11-06T10:01:15Z

ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/input-variables.md

@@ -647,6 +647,12 @@ roles/eos_cli_config_gen/docs/tables/management-api-gnmi.md
 roles/eos_cli_config_gen/docs/tables/monitor-connectivity.md
 --8<--

+### Monitor Server Radius


Suggested change

### Monitor Server Radius

### Monitor server Radius

ClausHolbechArista · 2024-11-06T10:02:12Z

...tions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/monitor-server-radius-2.yml

please refactor the tests to add to host-1 and host-2 instead.

for more information, see https://pre-commit.ci

sonarcloud · 2024-11-06T11:16:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions · 2024-11-06T17:00:06Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Oct 15, 2024

github-actions bot assigned laxmikantchintakindi Oct 15, 2024

github-actions bot added the state: Documentation role Updated label Oct 15, 2024

gmuloc added this to the v5.1.0-dev1 milestone Oct 15, 2024

laxmikantchintakindi force-pushed the feat/monitor-server-radius branch 3 times, most recently from e15c46b to d00db5d Compare October 16, 2024 06:09

MaheshGSLAB reviewed Oct 16, 2024

View reviewed changes

laxmikantchintakindi force-pushed the feat/monitor-server-radius branch from 7c3f23b to 64b925e Compare October 16, 2024 09:05

laxmikantchintakindi force-pushed the feat/monitor-server-radius branch 2 times, most recently from 152b0a8 to 6ef46b1 Compare October 28, 2024 06:52

MaheshGSLAB marked this pull request as ready for review October 29, 2024 05:52

MaheshGSLAB requested review from a team as code owners October 29, 2024 05:52

MaheshGSLAB reviewed Oct 29, 2024

View reviewed changes

python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/monitor-server-radius.j2 Outdated Show resolved Hide resolved

alexeygorbunov reviewed Oct 30, 2024

View reviewed changes

alexeygorbunov reviewed Nov 5, 2024

View reviewed changes

gmuloc requested changes Nov 5, 2024

View reviewed changes

laxmikantchintakindi requested review from alexeygorbunov and gmuloc November 6, 2024 09:11

ClausHolbechArista requested changes Nov 6, 2024

View reviewed changes

Laxmikant Chintakindi and others added 7 commits November 6, 2024 16:26

Feat(eos_cli_config_gen): Add support for monitor-server-radius

bd06570

Remove description for username and password

ced068c

Adding threshold failure command

0ca6c34

Modify description for access_request key.

4434391

[pre-commit.ci] auto fixes from pre-commit.com hooks

f514b70

for more information, see https://pre-commit.ci

Add doc template

b3b88e5

Fix CI.

747bf83

Laxmikant Chintakindi added 3 commits November 6, 2024 16:28

Update heading of table

cd3537d

Fix template and update input variable, pwd type description

c733718

Remove the doc which is not required and hide password in doc

893c34a

laxmikantchintakindi force-pushed the feat/monitor-server-radius branch from 092f828 to 893c34a Compare November 6, 2024 10:58

Laxmikant Chintakindi added 2 commits November 6, 2024 16:37

Move tests to host1 and host2

a21c10b

Remove old files from hosts

338c5c9

github-actions bot added the state: conflict PR with conflict label Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(eos_cli_config_gen): Add support for `monitor server radius` #4595

Feat(eos_cli_config_gen): Add support for `monitor server radius` #4595

laxmikantchintakindi commented Oct 15, 2024 •

edited

Loading

github-actions bot commented Oct 15, 2024

alexeygorbunov Oct 30, 2024

alexeygorbunov Nov 5, 2024

gmuloc Nov 5, 2024

laxmikantchintakindi Nov 6, 2024

gmuloc Nov 4, 2024

laxmikantchintakindi Nov 6, 2024

gmuloc Nov 4, 2024

laxmikantchintakindi Nov 6, 2024

gmuloc Nov 5, 2024

ClausHolbechArista Nov 6, 2024

laxmikantchintakindi Nov 6, 2024

ClausHolbechArista Nov 6, 2024

laxmikantchintakindi Nov 6, 2024

ClausHolbechArista Nov 6, 2024

laxmikantchintakindi Nov 6, 2024

ClausHolbechArista Nov 6, 2024

laxmikantchintakindi Nov 6, 2024

sonarcloud bot commented Nov 6, 2024

github-actions bot commented Nov 6, 2024

	probe method access-request username {{ access_request.username }} password {{ access_request.password_type \| arista.avd.default("7") }} {{ access_request.password }}
	probe method access-request username {{ access_request.username }} password {{ access_request.password_type \| arista.avd.default("7") }} {{ access_request.password \| arista.avd.hide_passwords(hide_passwords }}

	description: Server probe period in seconds.
	description: Server probe interval in seconds.

Feat(eos_cli_config_gen): Add support for monitor server radius #4595

Are you sure you want to change the base?

Feat(eos_cli_config_gen): Add support for monitor server radius #4595

Conversation

laxmikantchintakindi commented Oct 15, 2024 • edited Loading

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions bot commented Oct 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 6, 2024

Quality Gate passed

github-actions bot commented Nov 6, 2024

Feat(eos_cli_config_gen): Add support for `monitor server radius` #4595

Feat(eos_cli_config_gen): Add support for `monitor server radius` #4595

laxmikantchintakindi commented Oct 15, 2024 •

edited

Loading