Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Improve ptp settings for p2p_links #4612

Draft
wants to merge 10 commits into
base: devel
Choose a base branch
from
Draft

Feat(eos_designs): Improve ptp settings for p2p_links #4612

wants to merge 10 commits into from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Oct 18, 2024 •
edited
Loading

Change Summary

Improve ptp settings for p2p_links

Related Issue(s)

Fixes #2698

Component(s) name

arista.avd.eos_designs

Proposed changes

PTP knobs are available in connected_endpoints:

    ptp:
      enable: < true | false | default -> false | Required >
      # These are the default settings:
      # - The global PTP profile parameters will be applied to all connected endpoints where ptp is manually enabled.
      # - `ptp role master` is set to ensure control over the PTP topology.
      endpoint_role: < follower | bmca | default -> follower >
      profile: < aes67 | smpte2059-2 | aes67-r16-2016 | default -> aes67-r16-2016 >

These would be valuable to have also in l3_edge p2p_links for L3 devices.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Oct 18, 2024
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4612
# Activate the virtual environment
source test-avd-pr-4612/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/ptp-p2p-links#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/ptp-p2p-links --force
# Optional: Install AVD examples
cd test-avd-pr-4612
ansible-playbook arista.avd.install_examples

@laxmikantchintakindi laxmikantchintakindi changed the title Feat(eos_desings): Improve ptp settings for p2p_links Feat(eos_designs): Improve ptp settings for p2p_links Oct 18, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/ptp-p2p-links branch 3 times, most recently from 5504ee0 to 3477fa5 Compare October 24, 2024 06:13
MaheshGSLAB
MaheshGSLAB reviewed Oct 24, 2024
View reviewed changes
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_p2p_links.schema.yml Show resolved Hide resolved
...-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/ethernet_interfaces.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_p2p_links.schema.yml
type: str
default: "bmca"
valid_values:
- "bmca"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you confirm the role bmca. I see dynamic and master in eos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this as per comment from the issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @ClausHolbechArista

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use can add dynamic and master here. But then also please update the valid values for the endpoints to also accept dynamic (without removing bmca, but add deprecated in the description for bmca). Dynamic == bmca

...llections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/custom-ptp-profile.cfg
@@ -46,6 +46,7 @@ interface Ethernet8
ptp announce interval 4
ptp announce timeout 3
ptp delay-req interval -6
ptp role master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems role master is configure by default.

python-avd/pyavd/_eos_designs/structured_config/core_interfaces_and_l3_edge/utils.py Outdated
# Apply PTP profile config
if self.shared_utils.ptp_enabled:
ptp_config.update(self.shared_utils.ptp_profile)

ptp_config["enable"] = True

if get(p2p_link, "role") != "bmca":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it means default role is master which is not correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw similar logic in connected_endpoints.utils.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have different assumptions for endpoints and p2p links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic behaves different than the schema says. The schema says the default is "bmca", but your logic requires "bmca" to be set directly.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review October 28, 2024 10:13
carlbuchmann
carlbuchmann requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test coverage in eos_designs_unit_tests scenario

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft October 29, 2024 12:14
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review October 30, 2024 06:36
@laxmikantchintakindi
Copy link
Contributor Author

Please add test coverage in eos_designs_unit_tests scenario

Added.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft November 7, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaheshGSLAB MaheshGSLAB MaheshGSLAB left review comments

@carlbuchmann carlbuchmann carlbuchmann requested changes

@sugetha24 sugetha24 Awaiting requested review from sugetha24

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Requested changes must be addressed to merge this pull request.

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PTP knobs to l3_edge p2p_links
4 participants
@laxmikantchintakindi @carlbuchmann @ClausHolbechArista @MaheshGSLAB