Refactor(eos_cli_config_gen): Improve the aaa accounting j2 template #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4636
# Activate the virtual environment
source test-avd-pr-4636/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4630#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4630 --force
# Optional: Install AVD examples
cd test-avd-pr-4636
ansible-playbook arista.avd.install_examples |
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/aaa.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/aaa.cfg
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested changes
Nov 6, 2024
| @@ -44,3 +55,11 @@ aaa_accounting: | |||
| type: start-stop | |||
| logging: false | |||
| group: TACACS | |||
| # It should not include logging into command | |||
There was a problem hiding this comment.
Please add reasoning why, so these are easier to follow in the future.
| @@ -6,48 +6,50 @@ | |||
| {# eos - aaa accounting #} | |||
| {% if aaa_accounting is arista.avd.defined %} | |||
| {% if aaa_accounting.exec.console.type is arista.avd.defined %} | |||
There was a problem hiding this comment.
I think, the type key should be required here
There was a problem hiding this comment.
It could be breaking change but yes ideally as per j2 and EOS it should be a required key
cc @gmuloc @ClausHolbechArista
github-actions
bot
added
role: eos_cli_config_gen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Improve the aaa accounting j2 template.
Related Issue(s)
Fixes #4630
Component(s) name
arista.avd.eos_cli_config_genProposed changes
How to test
Run molecule with different type of inputs in aaa_accounting
Checklist
User Checklist
Repository Checklist