Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Include more molecule scenarios in pytest #4662

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Include more molecule scenarios in pytest

Proposed changes

  • To improve coverage in pytest we have now included more scenarios.
  • Changed the way we load the data to do it in pytest instead of the ansible playbook and make test-dep.

How to test

run tox -e coverage,report

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4662
# Activate the virtual environment
source test-avd-pr-4662/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@test/include-more-molecule-scenarios-in-pytest#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,test/include-more-molecule-scenarios-in-pytest --force
# Optional: Install AVD examples
cd test-avd-pr-4662
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 28, 2024
@github-actions github-actions bot added state: conflict PR with conflict labels Oct 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the test/include-more-molecule-scenarios-in-pytest branch from 1365549 to 96b69c4 Compare November 7, 2024 08:15
@ClausHolbechArista ClausHolbechArista force-pushed the test/include-more-molecule-scenarios-in-pytest branch from 96b69c4 to 6592ffb Compare November 7, 2024 08:55
@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 7, 2024
@ClausHolbechArista ClausHolbechArista merged commit 221cac0 into aristanetworks:devel Nov 7, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Test state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants