Fix(eos_validate_state): Fix the VerifyLLDPNeighbors test to skip in case validate_state is set to False #4679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4679
# Activate the virtual environment
source test-avd-pr-4679/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4675-bug#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4675-bug --force
# Optional: Install AVD examples
cd test-avd-pr-4679
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_validate_state
state: CI Updated
|
@bjmeuer can you please test this fix? Thanks! |
gmuloc
reviewed
Nov 4, 2024
There was a problem hiding this comment.
@MaheshGSLAB probably need to update some doc /schema description for the key as well
@ClausHolbechArista |
bjmeuer
approved these changes
Nov 4, 2024
github-actions
bot
added
state: Documentation role Updated
role: eos_designs
@gmuloc Updated the same. |
ClausHolbechArista
requested changes
Nov 5, 2024
4 tasks
github-actions
bot
added
the
role: eos_cli_config_gen
ClausHolbechArista
approved these changes
Nov 6, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the VerifyLLDPNeighbors test to skip in case validate_state is set to False.
Related Issue(s)
Partial fix of #4675. Addressing the bug.
Component(s) name
arista.avd.eos_validate_stateProposed changes
Added the logic to skip the VerifyLLDPNeighbors in case validate_state is set to False.
How to test
Set validate_state as false in connected endpoint and it should skip the VerifyLLDPNeighbors tests for those interfaces.
Checklist
User Checklist
Repository Checklist