CI(eos_cli_config_gen): Restructured the eos_cli_config_gen molecule host vars part-4 #4683
+807
−1,116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4683
# Activate the virtual environment
source test-avd-pr-4683/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@cli-restructure-part4#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,cli-restructure-part4 --force
# Optional: Install AVD examples
cd test-avd-pr-4683
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
MaheshGSLAB
commented
Nov 7, 2024
| @@ -15,7 +15,7 @@ | |||
| {% for ip_extcommunity_list in ip_extcommunity_lists_regexp | arista.avd.natural_sort('name') %} | |||
| {% for entry in ip_extcommunity_list.entries | arista.avd.default([]) %} | |||
| {% if entry.type is arista.avd.defined and entry.regexp is arista.avd.defined %} | |||
| | {{ ip_extcommunity_list.name }} | {{ entry.type }} | {{ entry.regexp }} | | |||
| | {{ ip_extcommunity_list.name }} | {{ entry.type }} | `{{ entry.regexp }}` | | |||
There was a problem hiding this comment.
Made the changes as MD lint was giving issue
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md:1183:31 MD052/reference-links-images Reference links and images should use a label that is defined [Missing link or image reference definition: "0-9"] [Context: "[0-9][0-9]"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Restructured the eos_cli_config_gen molecule host vars part-4
Related Issue(s)
Fixes #https://github.com/aristanetworks/avd-internal/issues/171
Component(s) name
arista.avd.eos_cli_config_genProposed changes
Restructured the eos_cli_config_gen molecule host vars
How to test
Run eos_cli_config_gen molecule then run tox command to generate the coverage report.
molecule converge -s eos_cli_config_gen
tox -e coverage,report
Checklist
User Checklist
Repository Checklist