Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Missing redistribution of attached-host to BGP #4696

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Missing redistribution of attached-host to BGP

Related Issue(s)

Fixes #4654

Component(s) name

arista.avd.eos_designs

Proposed changes

  • On the parent to devices using inband mgmt, the redistribute attached-host was missing from router bgp when using non-default VRFs.

How to test

Existing molecule showcased the issue, so it got updated with the fix.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Nov 7, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4696
# Activate the virtual environment
source test-avd-pr-4696/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/missing-bgp-redist-attached-host#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/missing-bgp-redist-attached-host --force
# Optional: Install AVD examples
cd test-avd-pr-4696
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 7, 2024
@gmuloc gmuloc requested a review from a team November 7, 2024 12:14
@gmuloc
Copy link
Contributor

gmuloc commented Nov 7, 2024

@dgonzalez85 can you please test the PR?

@gmuloc gmuloc added this to the v5.1.0-dev2 milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): L2LS Inband management in non-default VRF with BGP
2 participants