Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN #4752

wants to merge 2 commits into from
+10,641 −1,198

Conversation

ashenoy-arista
Copy link

@ashenoy-arista ashenoy-arista commented Nov 21, 2024 •
edited
Loading

Change Summary

Revised schema to support L3 Port-Channel interfaces and supporting changes to eos_designs
Primary use-case is to allow such interfaces as wan-facing interfaces.

Related Issue(s)

Fixes #4695

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

This change introduces revised schema within eos_designs with node key l3_port_channels
to represent L3 port-channel interfaces that may be used as wan-facing interfaces.
Includes logic to support the newly added schema and unit tests to validate handling of newly added schema attributes.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ashenoy-arista ashenoy-arista requested review from a team as code owners November 21, 2024 17:10
@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4752
# Activate the virtual environment
source test-avd-pr-4752/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ashenoy-arista/avd.git@samplePRBranch#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ashenoy-arista/avd.git#/ansible_collections/arista/avd/,samplePRBranch --force
# Optional: Install AVD examples
cd test-avd-pr-4752
ansible-playbook arista.avd.install_examples

@ashenoy-arista ashenoy-arista marked this pull request as draft November 21, 2024 17:10
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Nov 21, 2024
@github-actions github-actions bot removed role: eos_cli_config_gen issue related to eos_cli_config_gen role type: code quality CI and development toolset state: CI Updated CI scenario have been updated in the PR labels Nov 21, 2024
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from a8fa6b9 to 1d61e17 Compare November 27, 2024 20:49
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 3, 2024
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from cfae876 to fccd4c8 Compare December 3, 2024 04:05
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from b8175d8 to ffc3188 Compare December 5, 2024 06:50
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs): Add revised schema to support L3 Port-Channel interfaces Feat(eos_designs): Add suport for l3_port_channel_interfaces for WAN Dec 6, 2024
ClausHolbechArista
ClausHolbechArista requested changes Dec 6, 2024
View reviewed changes
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/shared_utils/l3_port_channels.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/shared_utils/wan.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/static_routes.py Outdated Show resolved Hide resolved
python-avd/pyavd/api/interface_descriptions/__init__.py Outdated Show resolved Hide resolved
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 3 times, most recently from c689203 to 41612ab Compare December 12, 2024 07:39
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 20, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 24, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ashenoy-arista ashenoy-arista changed the title Feat(eos_designs): Add suport for l3_port_channel_interfaces for WAN Feat(eos_designs): Add support for l3_port_channel_interfaces for WAN Jan 8, 2025
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 3 times, most recently from 9b5741b to d7b934f Compare January 10, 2025 00:48
gmuloc
gmuloc requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial review - need to continue but sending initial comments

ansible_collections/arista/avd/examples/cv-pathfinder/documentation/devices/site3-wan1.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/SITE3.yml Show resolved Hide resolved
ansible_collections/arista/avd/examples/cv-pathfinder/group_vars/TRANSPORTS.yml Outdated Show resolved Hide resolved
...ble_collections/arista/avd/examples/cv-pathfinder/intended/structured_configs/site3-wan1.yml Show resolved Hide resolved
...eos_designs_negative_unit_tests/inventory/host_vars/ipv4-acl-in-missing-on-wan-interface.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py Outdated Show resolved Hide resolved
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from bed5e26 to 455901f Compare January 16, 2025 23:07
@gmuloc gmuloc mentioned this pull request Jan 17, 2025
Merged
4 tasks
gmuloc
gmuloc requested changes Jan 17, 2025
View reviewed changes
...tive_unit_tests/inventory/host_vars/l3-port-channel-sub-interface-with-member-interfaces.yml Outdated Show resolved Hide resolved
..._designs_negative_unit_tests/inventory/host_vars/l3-port-channel-sub-interface-with-mode.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
...rista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/node-type-l3-port-channels.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/metadata/cv_tags.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/utils_wan.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/utils.py Outdated Show resolved Hide resolved
@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 2 times, most recently from 784fb81 to d2eb361 Compare January 18, 2025 01:55
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 20, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 22, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ashenoy-arista ashenoy-arista force-pushed the samplePRBranch branch 3 times, most recently from d5f0d7b to fd72134 Compare January 22, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi left review comments

@XiangyiGuo XiangyiGuo XiangyiGuo left review comments

@gmuloc gmuloc gmuloc requested changes

@ClausHolbechArista ClausHolbechArista Awaiting requested review from ClausHolbechArista

Requested changes must be addressed to merge this pull request.

Assignees

@ashenoy-arista ashenoy-arista

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add support for Port-Channels for WAN interfaces
6 participants
@ashenoy-arista @gmuloc @ClausHolbechArista @XiangyiGuo @laxmikantchintakindi @carlbuchmann