cgroup,cleaner: wait on level-triggered transitions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yabberyabber
approved these changes
Feb 5, 2024
This avoids killing an active cleaner when attaching to it via PTRACE_SEIZE, which is helpful when debugging.
Snaipe
force-pushed
the
fix/cgroup-leak-2
branch
from
104ac1c
to
949b3fc
Compare
The old code used edge-triggered transitions for epoll_wait on the cgroup.events file, which meant we were losing some events if we weren't fast enough to process them. This, in turn, caused the unlucky cleaner processes to hang on an epoll_wait, unable to clean up the unpopulated cgroup. With this commit, we now operate on level-triggered transitions, which allows cleaners to do their jobs properly.
Snaipe
force-pushed
the
fix/cgroup-leak-2
branch
from
949b3fc
to
2e775f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old code used edge-triggered transitions for epoll_wait on the
cgroup.events file, which meant we were losing some events if we weren't
fast enough to process them. This, in turn, caused the unlucky cleaner
processes to hang on an epoll_wait, unable to clean up the unpopulated
cgroup.
With this commit, we now operate on level-triggered transitions, which
allows cleaners to do their jobs properly.