fix(rollup): fix incorrect rollup configs #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Rollup config for cloudvision-connector references the `replace` plugin, but this is the wrong package to do that, since that package never uses `process.env` in its source code. This config belongs in a-msgpack, which does access `process.env` in its source. This fix will remove `process.env` from appearing in the build output of a-msgpack, where it appears currently and causes non-webpack callers to crash because `process` is not defined in a browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rollup config for cloudvision-connector references the
replaceplugin, but this is the wrong package to do that, since that package never usesprocess.envin its source code. This config belongs in a-msgpack, which does accessprocess.envin its source.This fix will remove
process.envfrom appearing in the build output of a-msgpack, where it appears currently and causes non-webpack callers to crash becauseprocessis not defined in a browser.