Refactor: Move to ruff for CI #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gmuloc
commented
Oct 1, 2024
gmuloc
commented
- drop Python 3.8 support
- Move to ruff to lint
- Refactor functions to use pathlib.Path in several places
| lint_warnings | ||
| a dictionary containing pairs of type {filename: list of warnings} | ||
| verbose | ||
| When True, output a string when no error nor warning was passed. |
There was a problem hiding this comment.
Suggested change
| When True, output a string when no error nor warning was passed. | |
| When True, output a string if neither an error nor a warning was passed. |
| Returns | ||
| ------- | ||
| tuple[int, int] | ||
| A two tuple containing the total number of errors and the total number of warnings. |
There was a problem hiding this comment.
Suggested change
| A two tuple containing the total number of errors and the total number of warnings. | |
| A tuple containing the total number of errors and the total number of warnings. |
| CONSOLE.rule(f"[bold red]JINJA2 LINT {issue_type}") | ||
| for key, issues in lint_issues.items(): | ||
| if not issues: | ||
| continue | ||
| tree = Tree(f"{key}") | ||
|
|
||
| for j2_issue in issues: | ||
| tree.add(j2_issue.to_rich(verbose)) | ||
| tree.add(j2_issue.to_rich(verbose=verbose)) | ||
| CONSOLE.print(tree) | ||
|
|
||
| total_lint_errors = sum(len(issues) for _, issues in lint_errors.items()) |
There was a problem hiding this comment.
Suggested change
| total_lint_errors = sum(len(issues) for _, issues in lint_errors.items()) | |
| total_lint_errors = sum(len(issues) for issues in lint_errors.values()) |
There was a problem hiding this comment.
same for warnings, not able to add comment on the line below
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.