Fix #19 #20
Open
Fix #19 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes aristanetworks#19 by downgrading the compiler to 8.10 (I still don't think 9.0 should be used in production). bytestring < 0.11.4 (which as of today has not been released to https://hackage.haskell.org/package/bytestring), is broken, as per haskell/bytestring#538. This in turn shows up in yesodweb/wai#894, and ultimately causes aristanetworks#19.
|
This will now use bytestring-0.10.12.0 instead of bytestring-0.11.3.1 |
|
Ok. This does not work, it did work in my shell because I had a newer cabal-install. However this change allows cabal2nix to parse it, but the |
|
This is now a very ugly hack that breaks macOS, but works on linux. I would not have expected me to break macOS. |
Gabriella439
approved these changes
Dec 14, 2022
Comment on lines
+19
to
+21
| # use cabal2nix from 9.2 here, because cabal2nix from 8.10 can't | ||
| # read cabal-version: 3.6 | ||
| pkgsNew.haskell.packages.ghc92.cabal2nix; |
There was a problem hiding this comment.
Do you still need this change if you downgrade the required Cabal version to 2.2?
There was a problem hiding this comment.
@angerman What do you think? I do not think this would be required.
jcumming
added a commit
to jcumming/nix-serve-ng
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #19 by downgrading the compiler to 8.10 (I still don't think 9.0 should be used in production). bytestring < 0.11.4 (which as of today has not been released to https://hackage.haskell.org/package/bytestring), is broken, as per haskell/bytestring#538. This in turn shows up in yesodweb/wai#894, and ultimately causes #19.