feat: only allow safe-precision integers to pass parsedInteger
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #743 This commit adds an additional check to the `parsedInteger` validator, using `Number.isSafeInteger()` to require that any parsed integer has maximum precision (cannot overflow). This better represents what the average user would want, but may fail on some valid inputs. An `unsafeParsedInteger` validator should be considered in the future. Due to many upcoming changes to error scopes, 'string' was used as the base type and the regex check was made in the narrow. The error message when a non-string is passed has changed slightly, just saying "must be a string" instead of "must be a well-formed integer string." This is a very minor change and can be dismissed. BREAKING CHANGE: Any unsafe integers that use the `parsedInteger` validator will now fail the validation. Signed-Off-By: LogN <[email protected]>
thetayloredman
changed the title
parsedIntegerparsedInteger
|
test failure not caused by this pr |
ssalbdivad
requested changes
May 4, 2023
|
Honestly I'm not going to worry about the docgen related failure on Windows, I'll look into that when I'm getting the perf branch merged 👍 |
ssalbdivad
changed the title
parsedIntegerparsedInteger
ahrjarrett
pushed a commit
to ahrjarrett/arktype-fork
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743
This commit adds an additional check to the
parsedIntegervalidator, usingNumber.isSafeInteger()to require that any parsed integer has maximum precision (cannot overflow). This better represents what the average user would want, but may fail on some valid inputs. AnunsafeParsedIntegervalidator should be considered in the future.Due to many upcoming changes to error scopes, 'string' was used as the base type and the regex check was made in the narrow. The error message when a non-string is passed has changed slightly, just saying "must be a string" instead of "must be a well-formed integer string." This is a very minor change and can be dismissed.
BREAKING CHANGE: Any unsafe integers that use the
parsedIntegervalidator will now fail the validation.