Skip to content

Commit

Permalink
Added documentation and corrected CHANGELOG.md
Browse files Browse the repository at this point in the history
  • Loading branch information
hdvanegasm committed Dec 20, 2023
1 parent 33299d2 commit 320ddb9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
- [\#689](https://github.com/arkworks-rs/algebra/pull/689) (`ark-serialize`) Add `CanonicalSerialize` and `CanonicalDeserialize` impls for `VecDeque` and `LinkedList`.
- [\#693](https://github.com/arkworks-rs/algebra/pull/693) (`ark-serialize`) Add `serialize_to_vec!` convenience macro.
- [\#713](https://github.com/arkworks-rs/algebra/pull/713) (`ark-ff`) Add support for bitwise operations AND, OR, and XOR between `BigInteger`.
- [\#736](https://github.com/arkworks-rs/algebra/pull/736) (`ark-ff`) Deprecate the use of `muln()` and `divn()`. Instead, it is implemented the traits `core::ops::Shl` and `core::ops::Shr` respectively.
- [\#736](https://github.com/arkworks-rs/algebra/pull/736) (`ark-ff`) Deprecate the use of `divn()`. Instead, it is implemented the trait `core::ops::Shr`.

### Breaking changes

Expand Down
5 changes: 5 additions & 0 deletions ff/src/biginteger/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,11 @@ impl<B: Borrow<Self>, const N: usize> BitOr<B> for BigInt<N> {
impl<const N: usize> Shr<u32> for BigInt<N> {
type Output = Self;

/// Computes bitwise shift right operation.
///
/// Differently from the built-in numeric types (u8, u32, u64, etc.) this
/// operation does *not* return an underflow error if the number of bits
/// shifted is larger than N * 64.
fn shr(self, mut rhs: u32) -> Self::Output {
let mut data = self.0.clone();

Expand Down

0 comments on commit 320ddb9

Please sign in to comment.