Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo : fixed minor typo in poly/src/valuation/dense.rs #688

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix typo : fixed minor typo in poly/src/valuation/dense.rs #688

merged 1 commit into from
Oct 11, 2023

Conversation

Leegwangwoon
Copy link
Contributor

Description

--> in this PR, fixed some minor typo in dense.rs. In the line 96 ~ 97, i think the hypercube operation result should be changed.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • [v] Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@Leegwangwoon Leegwangwoon requested review from a team as code owners October 6, 2023 09:57
@Leegwangwoon Leegwangwoon requested review from z-tech, Pratyush and mmagician and removed request for a team October 6, 2023 09:57
Pratyush
Pratyush approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

weikengchen
weikengchen approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@weikengchen weikengchen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a calculation and the MLE result on (1, 17) should still be 54. So we are merged this PR.

But, this issue was not caught before. Our CI doesn't check examples?

@Leegwangwoon
Copy link
Contributor Author

Thank you

@Pratyush Pratyush merged commit 9f9edac into arkworks-rs:master Oct 11, 2023
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@Leegwangwoon @aleasims
fix typo : fixed minor typo in poly/src/valuation/dense.rs (arkworks-…
4ef7268 
…rs#688)
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
@aleasims
Revert "fix typo : fixed minor typo in poly/src/valuation/dense.rs (a…
e637eb1 
…rkworks-rs#688)"

This reverts commit 4ef7268.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikengchen weikengchen weikengchen approved these changes

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leegwangwoon @Pratyush @weikengchen