Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching attributes in MontConfig macro #747

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Fix fetching attributes in MontConfig macro #747

merged 2 commits into from
Jan 11, 2024

Conversation

aleasims
Copy link
Contributor

@aleasims aleasims commented Jan 11, 2024 •
edited
Loading

Description

Previously fetching function was panicing on every different attribute. Now it simply skips attributes of different format. As a result, it is possible now to apply other attributes when defining strucutre with MontConfig.

closes: #704

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@aleasims
Fix fetching attributes in MontConfig macro
bb71132 
Previously fetching function was panicing on every different attribute.
Now it simply skips attributes of different format.  As a result, it is possible
now to apply other attributes when defining strucutre with MontConfig.
Original issue is arkworks-rs#704
@aleasims
Update CHANGELOG after fixing bug arkworks-rs#704
c6472dd
@aleasims
Copy link
Contributor Author

aleasims commented Jan 11, 2024 •
edited
Loading

Notes:

  • I didn't find any testing in this crate, so I didn't add any unit tests.
  • I didn't find any relevant docs which can be updated alongside with these changes

@aleasims aleasims marked this pull request as ready for review January 11, 2024 19:19
@aleasims aleasims requested review from a team as code owners January 11, 2024 19:19
@aleasims aleasims requested review from z-tech, Pratyush and mmagician and removed request for a team January 11, 2024 19:19
@aleasims aleasims mentioned this pull request Jan 11, 2024
Closed
Pratyush
Pratyush approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Pratyush Pratyush added this pull request to the merge queue Jan 11, 2024
Merged via the queue into arkworks-rs:master with commit 809be96 Jan 11, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Derive macro MontConfig panics if any other attribute is applied
2 participants
@aleasims @Pratyush