Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@Pratyush Here is my proposal to implement the first element of the binary tower, the basic binary field. The inspiration is taken from Binius repo: https://gitlab.com/IrreducibleOSS/binius
SmallU
to benefit from the small size of the u8, then we can do something like what is proposed here https://gitlab.com/IrreducibleOSS/binius/-/blob/main/crates/field/src/binary_field.rs#L709I haven't made a macro yet because this is a first proposal with a single field. At first I think we can make several small basic PRs without a macro and see if at the end we can refactor with a macro but I don't think it's necessarily useful right away. Also for the
Bf128
, I think we can use the polyval base which seems a little more efficient (to test: https://github.com/RustCrypto/universal-hashes/tree/master/polyval) and so maybe it won't fit in the macro either, we'll see.@Pratyush Please provide feedback so that we can merge quite fast and iterate on that with small issues.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer