Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.5 #68

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Release 0.5 #68

wants to merge 24 commits into from

Conversation

mmagician
Copy link
Member

@mmagician mmagician commented Jul 13, 2024

  • fully deprecate circom1, and thus remove make circom-2 feature the default,
  • simplify the traits, we no longer need CricomBase vs. Circom1 & Circom2. Directly implement all the methods on the Wasm struct,
  • update the dependencies to 0.5.0-alpha
  • adapt version numbering for org consistency

@mmagician mmagician marked this pull request as ready for review July 17, 2024 21:52
@mmagician mmagician marked this pull request as draft July 17, 2024 22:00
@mmagician
Copy link
Member Author

This code works now after arkworks-rs/groth16#61 has been merged and groth 0.5.0-alpha.1 released. Let's keep it as a branch for now till we upgrade all other repos

@anudit
Copy link

anudit commented Jul 18, 2024

@mmagician Just tried the 0.5.0-alpha.1 release, proof verification seems to work 🚀

image

@Pratyush
Copy link
Member

Thanks @mmagician; could you also update the README to change the line about adding ark-circom as a dependency to use the crates version instead?

Also, @tyshko-rostyslav, could you please authorize the crates-io team within the arkworks organization to make releases for the ark-circom crate?

mmagician and others added 2 commits July 19, 2024 12:53
After forcing `wasmer-wasix` to use the `js` feature when the
`circom-compat/js` feature is enabled. As well as forcing `wasmer/js`
and otherwise, `wasmer/default`. The crate can now successfully compile
to wasm.

Resolves: #73
@tyshko-rostyslav
Copy link
Collaborator

Thanks @mmagician; could you also update the README to change the line about adding ark-circom as a dependency to use the crates version instead?

Also, @tyshko-rostyslav, could you please authorize the crates-io team within the arkworks organization to make releases for the ark-circom crate?

Sure, but as far as I understand from docs you need to have a team in arkworks-rs created. Otherwise I could add people one by one, whatever is easier for you

@mmagician
Copy link
Member Author

@tyshko-rostyslav There is a crates.io team in the arkworks-rs organization: https://crates.io/teams/github:arkworks-rs:crates-io

@tyshko-rostyslav
Copy link
Collaborator

@tyshko-rostyslav There is a crates.io team in the arkworks-rs organization: https://crates.io/teams/github:arkworks-rs:crates-io

As per docs I have to be a member of your team to be able to give the team access. Could you please (temporarily) add me to that team?

@mmagician
Copy link
Member Author

@Pratyush

@tyshko-rostyslav
Copy link
Collaborator

@Pratyush

Thanks! Added the team

@mmagician
Copy link
Member Author

@mmagician
Copy link
Member Author

@CPerezz I ended up upgrading the dependencies for wasmer. I added CI for this as well, but could you still confirm the new alpha release works on your setup please?

@CPerezz
Copy link

CPerezz commented Sep 11, 2024

@CPerezz I ended up upgrading the dependencies for wasmer. I added CI for this as well, but could you still confirm the new alpha release works on your setup please?

Hey, this target and setup work for the build and check. Also, couple things to at least mention.

In any case, definitely looks well! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants