-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and update dependencies to 0.3 #88
base: constraints
Are you sure you want to change the base?
Conversation
We should indeed deprecate fiat_shamir::AlgebraicSponge entirely |
src/lib.rs
Outdated
//#![deny(unused_import_braces, unused_qualifications, trivial_casts)] | ||
//#![deny(trivial_numeric_casts, private_in_public)] | ||
//#![deny(stable_features, unreachable_pub, non_shorthand_field_patterns)] | ||
//#![deny(unused_attributes, unused_imports, unused_mut)] | ||
//#![deny(renamed_and_removed_lints, stable_features, unused_allocation)] | ||
//#![deny(unused_comparisons, bare_trait_objects, unused_must_use, const_err)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change these to warn
s, like the main branch has
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, forgot these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideas to fix the test? |
/// The interface for a cryptographic sponge constraints on field `F`. | ||
/// A sponge can `absorb` or take in inputs and later `squeeze` or output bytes or field elements. | ||
/// The outputs are dependent on previous `absorb` and `squeeze` calls. | ||
pub trait CryptographicSpongeVarNonNative<F: PrimeField, CF: PrimeField, S: CryptographicSponge>: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not seem this trait has been implemented in this PR.
Description
The branch
constraints
isn't building with latest dependencies.Open questions
DensePolynomial<F>
concretely in some places, and expect the genericPC::BatchProof
in othersfiat_shamir::AlgebraicSponge
looks duplicate toark_sponge::CryptographicSponge
and should possibly be replacedcloses: #87
constraints
so the latter can be merged tomaster
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer