Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraints #47

Open
wants to merge 63 commits into
base: master
Choose a base branch
from
Open

Constraints #47

wants to merge 63 commits into from

Conversation

npwardberkeley
Copy link
Contributor

No description provided.

@Pratyush
Copy link
Member

Pratyush commented Oct 29, 2020 •
edited
Loading

Ok now that #46 is merged, this needs to be rebased atop master

@npwardberkeley
Copy link
Contributor Author

Yeet will do

@npwardberkeley
Copy link
Contributor Author

Rebased!

@npwardberkeley
Copy link
Contributor Author

oh lol it doesn't build. fixing...

@weikengchen
Copy link
Member

No_std passes.

@weikengchen weikengchen self-requested a review November 12, 2020 06:15
@weikengchen
Copy link
Member

I am going to add a feature about nonnative's density-optimization as well as do a final pass of this PR.

@Pratyush
Copy link
Member

Thanks, I think that'll make the implementation clearer as well.

howardwu and others added 2 commits January 29, 2021 08:57
@howardwu
Updates Marlin constraints to latest LC representation (#68)
5a2ef01 
* Updates marlin constraints to latest LC representation

* Cargo fmt
@weikengchen
bump digest abnd blake2
ebcf462
@weikengchen weikengchen mentioned this pull request Feb 8, 2021
Merged
@weikengchen
Copy link
Member

I will be back tomorrow to continue working on this. The rest is to apply previous code review comments.

We might need to split the constraints.rs into a file for its data structures---otherwise, it is way too long.

@howardwu This should reconcile with the upstream changes where the CycleEngine is deprecated. Tomorrow I will jump into Marlin to get it working.

@ValarDragon
Copy link
Member

Would you like more reviews on this PR? If so, could there be a short description written up for what its doing? Happy to review then

Pratyush
Pratyush reviewed Mar 8, 2022
View reviewed changes
src/marlin/marlin_pc/data_structures.rs
Comment on lines -47 to -50
pub fn powers<'a>(&'a self) -> kzg10::Powers<'a, E> {
pub fn powers<'a>(&self) -> kzg10::Powers<'a, E> {
kzg10::Powers {
powers_of_g: self.powers.as_slice().into(),
powers_of_gamma_g: self.powers_of_gamma_g.as_slice().into(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary? We rely heavily on the non-cloning nature of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weikengchen weikengchen weikengchen left review comments

@Pratyush Pratyush Pratyush left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@npwardberkeley @Pratyush @weikengchen @ValarDragon @oblivious-app @howardwu @Will-Lin4 @vlopes11