Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve KZG10 and multilinear-pc verification speed #98

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

improve KZG10 and multilinear-pc verification speed #98

wants to merge 7 commits into from

Conversation

zhenfeizhang
Copy link
Contributor

@zhenfeizhang zhenfeizhang commented May 3, 2022 •
edited
Loading

Description

A simple trick that will save ~1.5 ms for both KZG and ml-pc verification.

The currently building is broken so I tested against v0.3.0 release and it was fine.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@zhenfeizhang zhenfeizhang marked this pull request as ready for review May 3, 2022 18:02
@zhenfeizhang zhenfeizhang mentioned this pull request May 3, 2022
Closed
@zhenfeizhang zhenfeizhang changed the title improve KZG10 verification speed improve KZG10 and multilinear-pc verification speed May 20, 2022
Pratyush
Pratyush reviewed May 20, 2022
View reviewed changes
src/kzg10/mod.rs Outdated Show resolved Hide resolved
Pratyush
Pratyush reviewed May 20, 2022
View reviewed changes
src/kzg10/mod.rs Outdated Show resolved Hide resolved
@Pratyush
Copy link
Member

Thanks!

@Pratyush
Copy link
Member

btw could you resolve the merge conflict?

@zhenfeizhang
Copy link
Contributor Author

btw could you resolve the merge conflict?

Should be fixed by now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhenfeizhang @Pratyush