fix: address clippy warnings to improve code quality #400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several Clippy warnings throughout the codebase to improve code quality and readability:
constraint_system_ref.rs
, replacedmap(|x| x.clone())
with more idiomaticcloned()
methodinstance_outliner.rs
, introduced a type aliasInstanceOutliningFunction<F>
for the complex function type to improve code readabilityconstraint_system.rs
, replacedmap().flatten()
pattern with the more efficientand_then()
methodvariable.rs
, fixed non-canonical implementation ofPartialOrd
forVariable
by using the canonical pattern that leverages the already implementedOrd
traitsnark/src/lib.rs
, introduced a type aliasIndexResult
for the complex return type in theUniversalSetupSNARK
traitThese changes make the code more idiomatic, more readable, and follow Rust best practices. The changes are purely refactoring and don't affect functionality.
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer