Skip to content

Commit

Permalink
Reapply 44c0719 with fix; NFC (#125100)
Browse files Browse the repository at this point in the history
Silence MSVC warnings; NFC
After the changes to DynamicRecursiveASTVisitor, we started getting
several warnings from MSVC like:

warning C4661: 'bool
clang::DynamicRecursiveASTVisitorBase<false>::WalkUpFromNamedDecl(clang::NamedDecl
*)': no suitable definition provided for explicit template instantiation
request

These changes silence the warnings by providing a definition for those
functions.
  • Loading branch information
AaronBallman authored Jan 30, 2025
1 parent 0d46657 commit 72efe15
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions clang/include/clang/AST/DynamicRecursiveASTVisitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,11 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase {
// Decls.
#define ABSTRACT_DECL(DECL)
#define DECL(CLASS, BASE) \
bool WalkUpFrom##CLASS##Decl(MaybeConst<CLASS##Decl> *D); \
virtual bool Traverse##CLASS##Decl(MaybeConst<CLASS##Decl> *D);
#include "clang/AST/DeclNodes.inc"

#define DECL(CLASS, BASE) \
bool WalkUpFrom##CLASS##Decl(MaybeConst<CLASS##Decl> *D); \
virtual bool Visit##CLASS##Decl(MaybeConst<CLASS##Decl> *D) { return true; }
#include "clang/AST/DeclNodes.inc"

Expand All @@ -272,11 +272,11 @@ template <bool IsConst> class DynamicRecursiveASTVisitorBase {
// Types.
#define ABSTRACT_TYPE(CLASS, BASE)
#define TYPE(CLASS, BASE) \
bool WalkUpFrom##CLASS##Type(MaybeConst<CLASS##Type> *T); \
virtual bool Traverse##CLASS##Type(MaybeConst<CLASS##Type> *T);
#include "clang/AST/TypeNodes.inc"

#define TYPE(CLASS, BASE) \
bool WalkUpFrom##CLASS##Type(MaybeConst<CLASS##Type> *T); \
virtual bool Visit##CLASS##Type(MaybeConst<CLASS##Type> *T) { return true; }
#include "clang/AST/TypeNodes.inc"

Expand Down

0 comments on commit 72efe15

Please sign in to comment.