chore: massive redo of Operator (#295)

* chore: massive redo of Operator * fix bugs with webhooks * fix build ci workflow * fix invalid echo in test workflow * delete redundant webhooks test in api package
armadaproject · Dec 12, 2023 · 4e1b2a6 · 4e1b2a6
1 parent bda0e29
commit 4e1b2a6
Show file tree

Hide file tree

Showing 75 changed files with 6,161 additions and 565 deletions.
diff --git a/.github/actions/setup-go-cache/action.yml b/.github/actions/setup-go-cache/action.yml
@@ -0,0 +1,37 @@
+name: "Setup Go"
+description: "Setup Go with caching"
+inputs:
+  cache-prefix:
+    description: "Prefix for the cache key"
+    required: false
+    default: "go"
+  disable-cache:
+    description: "Disable caching"
+    required: false
+    default: "false"
+  go-version:
+    description: "Version of Go. Default 1.21"
+    required: false
+    default: "1.21"
+outputs:
+  go-version:
+    description: "The installed Go version"
+    value: ${{ steps.setup-go.outputs.go-version }}
+runs:
+  using: "composite"
+  steps:
+    - id: setup-go
+      uses: actions/setup-go@v4
+      with:
+        go-version: ${{ inputs.go-version }}
+        check-latest: true
+        cache: false
+    - id: cache-info
+      if: ${{ inputs.disable-cache != 'true' }}
+      shell: bash
+      run: echo path=$(go env GOCACHE) >> $GITHUB_OUTPUT
+    - uses: actions/cache@v3
+      if: ${{ inputs.disable-cache != 'true' }}
+      with:
+        path: ${{ steps.cache-info.outputs.path }}
+        key: ${{ inputs.cache-prefix }}-go-${{ steps.setup-go.outputs.go-version }}-mod-${{ hashFiles('go.sum') }}
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -0,0 +1,32 @@
+name: Build
+
+on:
+  workflow_call:
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup Go
+        id: setup-go
+        uses: ./.github/actions/setup-go-cache
+        with:
+          cache-prefix: go-build
+
+      - name: Set up Docker Buildx
+        id: buildx
+        uses: docker/setup-buildx-action@v2
+
+      - uses: goreleaser/goreleaser-action@v5
+        with:
+          distribution: goreleaser
+          version: v1.22.1
+          args: build --snapshot --clean
+        env:
+          DOCKER_REPO: "gresearch"
+          GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
+          DOCKER_BUILDX_BUILDER: "${{ steps.buildx.outputs.name }}"
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,6 +25,8 @@ jobs:
     uses: ./.github/workflows/test.yml
   codeql:
     uses: ./.github/workflows/codeql.yml
+  build:
+    uses: ./.github/workflows/build.yml
   # Virtual job that can be configured as a required check before a PR can be merged.
   all-required-checks-done:
     name: All required checks done
@@ -33,7 +35,8 @@ jobs:
       - lint
       - test
       - codeql
-    runs-on: ubuntu-22.04
+      - build
+    runs-on: ubuntu-latest
     steps:
       - uses: actions/github-script@v6
         with:

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
@@ -31,19 +31,14 @@ jobs:
       fail-fast: false
       matrix:
         language: ['go']
-        go: [ '1.20' ]
+        go: [ '1.21' ]
         # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
         # Learn more:
         # https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Setup Golang with cache
-        uses: magnetikonline/action-golang-cache@v4
-        with:
-          go-version: "1.20"
+        uses: actions/checkout@v4
 
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL

diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -10,20 +10,19 @@ permissions:
 jobs:
   go-lint:
     name: Golang Lint
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Setup Golang with cache
-        uses: magnetikonline/action-golang-cache@v4
+      - uses: actions/setup-go@v4
         with:
-          go-version: "1.20"
+          go-version: '1.21'
+          cache: false
 
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
           version: "latest"
-          skip-pkg-cache: true
-          skip-build-cache: true
-          args: "-c ./.golangci.yml --timeout=10m --issues-exit-code=1 --max-issues-per-linter=0 --sort-results ./..."
+          only-new-issues: true
+          args: "-c ./.golangci.yml --timeout=10m --issues-exit-code=1 --sort-results ./..."
diff --git a/.github/workflows/lint_pr.yml b/.github/workflows/lint_pr.yml
@@ -10,7 +10,7 @@ on:
 jobs:
   main:
     name: Validate PR title
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     steps:
       - uses: amannn/action-semantic-pull-request@v5
         env:

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -14,11 +14,11 @@ jobs:
   validate:
     if: github.event.workflow_run.event == 'push' && github.event.workflow_run.conclusion == 'success' && github.repository_owner == 'armadaproject'
     name: "Validate revision"
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v3"
+        uses: "actions/checkout@v4"
         with:
           fetch-depth: 0
 
@@ -40,22 +40,23 @@ jobs:
   release:
     name: "Release"
     needs: validate
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     environment: armada-dockerhub
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
       - name: Fetch Git tags
         run: git fetch --force --tags
 
-      - name: Set up Go
-        uses: actions/setup-go@v4
+      - name: Setup Go
+        id: setup-go
+        uses: ./.github/actions/setup-go-cache
         with:
-          go-version: "1.20"
+          cache-prefix: go-build
 
       - name: Set up Docker Buildx
         id: buildx
@@ -78,18 +79,17 @@ jobs:
           echo "GORELEASER_PREVIOUS_TAG=$previous_tag" >> $GITHUB_ENV
 
       - name: Run GoReleaser
-        uses: goreleaser/goreleaser-action@v4
+        uses: goreleaser/goreleaser-action@v5
         with:
           distribution: goreleaser
-          version: v1.19.2
+          version: v1.21.1
           args: "-f ./.goreleaser.yaml release --clean"
         env:
           FULL_RELEASE: true
           DOCKER_REPO: "gresearch"
           GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           DOCKER_BUILDX_BUILDER: "${{ steps.buildx.outputs.name }}"
-          DOCKER_BUILDX_CACHE_FROM: "type=gha"
-          DOCKER_BUILDX_CACHE_TO: "type=gha,mode=max"
+
   invoke-chart-push:
     name: Invoke Chart push
     needs: release

diff --git a/.github/workflows/release_rc.yml b/.github/workflows/release_rc.yml
@@ -14,11 +14,11 @@ jobs:
   validate:
     if: github.event.workflow_run.event == 'push' && github.event.workflow_run.conclusion == 'success' && github.repository_owner == 'armadaproject'
     name: "Validate revision"
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v3"
+        uses: "actions/checkout@v4"
         with:
           fetch-depth: 0
 
@@ -40,19 +40,20 @@ jobs:
   release:
     name: Release
     needs: validate
-    runs-on: "ubuntu-22.04"
+    runs-on: "ubuntu-latest"
     environment: armada-dockerhub
 
     steps:
       - name: "Checkout"
-        uses: "actions/checkout@v3"
+        uses: "actions/checkout@v4"
         with:
           fetch-depth: 0
 
-      - name: Setup Golang with Cache
-        uses: magnetikonline/action-golang-cache@v4
+      - name: Setup Go
+        id: setup-go
+        uses: ./.github/actions/setup-go-cache
         with:
-          go-version: "1.20"
+          cache-prefix: go-build
 
       - name: Set up Docker Buildx
         id: buildx
@@ -65,17 +66,15 @@ jobs:
           password: "${{ secrets.DOCKERHUB_PASS }}"
 
       - name: "Run GoReleaser"
-        uses: "goreleaser/goreleaser-action@v4"
+        uses: "goreleaser/goreleaser-action@v5"
         with:
           distribution: "goreleaser"
-          version: v1.19.2
+          version: v1.21.1
           args: "-f ./.goreleaser.yaml release --snapshot --skip-sbom --skip-sign --clean"
         env:
           DOCKER_REPO: "gresearch"
           GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
           DOCKER_BUILDX_BUILDER: "${{ steps.buildx.outputs.name }}"
-          DOCKER_BUILDX_CACHE_FROM: "type=gha"
-          DOCKER_BUILDX_CACHE_TO: "type=gha,mode=max"
 
       - name: Run Docker push script
         run: ./scripts/docker-push.sh -t '${{ github.event.workflow_run.head_sha }}'