Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controller panics due to missing defaults #340

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

dejanzele
Copy link
Member

@dejanzele dejanzele commented Nov 26, 2024

Pull Request Template

Description

Please include a summary of the changes and the related issue (if any). Describe your changes in detail to help reviewers understand your contribution.

  • What is the purpose of this PR?
    Scheduler Controller erroring due to missing defaults for Pruner
  • What was changed?
    Added better checks and safe guards
  • Why was it changed?
    Panics prevent Operator from working and reconciling as expected
  • Does this address any existing issues or enhancement requests?

Fixes # (issue)

Type of change

Please select the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code Style Update (formatting, renaming)
  • Refactor (code changes that do not fix a bug or add a feature)
  • Documentation Update
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions to reproduce these tests. List any relevant details for your test configuration.

  • Test Configuration:

    • Kubernetes Version:
    • Helm Version:
    • OS:
  • Test Steps:

    1. Step 1
    2. Step 2
    3. ...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@dejanzele dejanzele force-pushed the fix/controller-panics branch from d288b84 to 6131e5b Compare November 26, 2024 12:46
@dejanzele dejanzele force-pushed the fix/controller-panics branch from 6131e5b to 9eb0e20 Compare November 26, 2024 12:52
@dejanzele dejanzele force-pushed the fix/controller-panics branch from dbeadd5 to 0bf9ad8 Compare November 26, 2024 15:37
@dejanzele dejanzele merged commit 122dba3 into main Nov 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants