Add a reason for preemption #3881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will now be populated with a cause for the job to be preempted Allowing you to distinguish: - If this Preemption was caused by API request - If this Preemption was caused by Fair share preemption - and the preempting job id - If this Preemption was caused by Urgency based preemption - and the preempting job id(s) - We cannot always narrow this down to a single job, so it will be a comma separated list of job ids Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]> # Conflicts: # internal/scheduler/common.go # internal/scheduler/nodedb/nodedb.go # internal/scheduler/scheduler.go # internal/scheduler/scheduling/context/pod.go # internal/scheduler/scheduling/preempting_queue_scheduler.go # internal/server/event/conversion/conversions.go # pkg/armadaevents/events.pb.go # pkg/armadaevents/events.proto
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
Signed-off-by: JamesMurkin <[email protected]>
JamesMurkin
changed the title
Signed-off-by: JamesMurkin <[email protected]>
d80tb7
previously approved these changes
Nov 3, 2024
Signed-off-by: JamesMurkin <[email protected]>
d80tb7
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to specify a reason for preemption when requesting a preemption via the API, this reason will appear in the public events.
The scheduler will also populate a reason for why the job was preempted
Allowing you to distinguish: