Preempt/Cancel on executor #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| cmd.Flags().StringSliceP("match-queues", "q", []string{}, "Cancel jobs on executor matching the specified queue names. If no queues are provided, jobs across all queues will be cancelled.") | ||
| return cmd |
There was a problem hiding this comment.
Suggest
- rename
--match-queuesto just--queues - for consistency, if
--queuesrequires a command line argument, then priority classes should require a--priority-classesarg. - comment should specify what the delimiter is if you want to cancel multiple queues
|
|
||
| return a.PreemptOnExecutor(onExecutor, matchQueues, onPriorityClasses) | ||
| }, | ||
| } |
There was a problem hiding this comment.
Similar to last comment
internal/armadactl/preempt.go
Outdated
| queueMsg = "all" | ||
| } | ||
|
|
||
| fmt.Fprintf(a.Out, "Requesting preemption of jobs matching executor: %s, queues: %s, priority-classes: %s\n", executor, queueMsg, priorityClasses) |
There was a problem hiding this comment.
You need to string.join(priorityClasses) as you did with queues
| ON jr.job_id = j.job_id | ||
| WHERE jr.executor = $1 | ||
| AND j.queue = ANY($2::text[]) | ||
| AND jr.succeeded = false AND jr.failed = false AND jr.cancelled = false |
There was a problem hiding this comment.
Also AND jr.preempted = false
…i/job-controls-on-executor
… formatted priority classes message to Armadactl app
robertdavidsmith
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes: