-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display "repeat build options" at the end if process was cancelled #6379
base: main
Are you sure you want to change the base?
Conversation
Currently "Repeat Build Options" in case of break prints 2 times:
Seems print operator added to the wrong place. |
IMO better is at the end. |
Confirm, better in the end. But I add one string into one place :) |
Yeah, compare:
One has a whale while the other doesn't. |
Insert print into end |
Next try: diff --git a/lib/functions/cli/entrypoint.sh b/lib/functions/cli/entrypoint.sh
index a1ca19383..0655b446f 100644
--- a/lib/functions/cli/entrypoint.sh
+++ b/lib/functions/cli/entrypoint.sh
@@ -179,4 +179,10 @@ function cli_entrypoint() {
# Build done, run the cleanup handlers explicitly.
# This zeroes out the list of cleanups, so it"s not done again when the main script exits normally and trap = 0 runs.
run_cleanup_handlers
+
+ # Gather repeat build args, included in the logs.
+# declare -g repeat_args=()
+ produce_repeat_args_array # produces repeat_args
+ declare repeat_args_string="${repeat_args[*]}"
+ display_alert "Repeat Build Options" "${repeat_args[*]}" "ext" # * = expand array, space delimited, single-word.
} I see it prints string I use as command line, not string need to repeat build. It's not the same if some parameter entered via menu. Example: |
Description
Currently "Repeat Build Options" shows at the end of screen log only if process was successfully finished.
This change adds "Repeat Build Options" text on the screen at the end of visible log.