Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add board config for MXQ TV box #7501

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add board config for MXQ TV box #7501

wants to merge 2 commits into from

Conversation

domin144
Copy link

@domin144 domin144 commented Nov 19, 2024

Description

This change introduces a config for MXQ TV box based on S805 chip. This revives the s805_autoscript file, which is being sought for by the factory boot loader, making it possible to boot from SD card.

How Has This Been Tested?

I built an image with:

./compile.sh build BOARD=aml-s805-mxq BRANCH=edge BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED='browsers internet multimedia' DESKTOP_ENVIRONMENT=xfce DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base KERNEL_CONFIGURE=no RELEASE=bookworm

I flashed an image on an SD card and booted the board. I was able to run xserver with display connected on integrated HDMI port and use mouse and keyboard connected to USB ports. Ethernet connection was working too.

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Notice

This is my first PR to this project, so any advice is appreciated. The board support and testing is not of high quality, but should not affect any other board and give good starting point for further work. Prior to these changes running armbian on the MXQ board requires non-trivial, manual adjustments to the image.

@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 19, 2024
@igorpecovnik igorpecovnik added the 02 Milestone: First quarter release label Nov 20, 2024
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Dec 6, 2024
@igorpecovnik
Copy link
Member

This is my first PR to this project, so any advice is appreciated.

Check if you can make use of existing boot scripts.

BOOTFS_TYPE="fat"
BOOT_LOGO=desktop

family_tweaks() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to:
function post_family_tweaks__aml_s805_logo() {

And does logo shows?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall seeing the logo. I don't install the image to builtin memory. I rely on the factory intalled u-boot to load armbian from SD card. That's why some content of the boot partition are unused, at least for now. This fragment is left over after starting from other board's config.
I will remove it.

I am away from home and have no access to the test device. I will update and test, but it will be sometime in January.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it.

OK, it probably doesn't work.

but it will be sometime in January.

No worries.

@igorpecovnik igorpecovnik added Work in progress Unfinished / work in progress and removed Ready to merge Reviewed, tested and ready for merge labels Dec 13, 2024
@domin144
Copy link
Author

This is my first PR to this project, so any advice is appreciated.

Check if you can make use of existing boot scripts.

Odroid-c1 and onecloud are the closest boards, but neither script will work out of the box due to hard-coded dtb path. I could try to extend one of those scripts, but this is additional risk of breaking those boards (I have no access to those boards to test). I think it should better be done under a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... size/medium PR with more then 50 and less then 250 lines Work in progress Unfinished / work in progress
Development

Successfully merging this pull request may close these issues.

2 participants