Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for NanoPi R3S #7556

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

EvilOlaf
Copy link
Member

@EvilOlaf EvilOlaf commented Dec 9, 2024

Description

This PR adds support for the NanoPi R3S SBC
https://www.friendlyelec.com/index.php?route=product/product&product_id=303

u-boot patchset borrowed from OpenWRT
Linux dts backported from 6.13

How Has This Been Tested?

Whoever has this board and want to test, plz do and give feedback.
https://fi.mirror.armbian.de/.testing/Armbian-unofficial_24.11.0-trunk_Nanopi-r3s_bookworm_edge_6.12.3_minimal.img.xz
Image with the updated u-boot patchset check comments below

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Dec 9, 2024
@EvilOlaf
Copy link
Member Author

EvilOlaf commented Dec 19, 2024

More or less just a note for further improvements:

OpenWRT also made adjustments to led and added some load balancing by setting net-smp-affinity

openwrt/openwrt@2902b0a#diff-f9d4f9cb6007e346ac46a85b5e28121e8bd2b0b18c2f91f5eab28b28b443f425

https://github.com/openwrt/openwrt/pull/16738/files#diff-86143a4e522eb5736b3b087ac4616281018f80fe24df29d3c5292f84616d521c

@rpardini
Copy link
Member

Looks good.

I guess the vendor u-boot doesn't build (it seems to try to use binman-style build with the 2017 vendor u-boot, which is a no-go).

We need to add some bare-DT/bare-defconfig (thus avoiding null-patches) support to mainline (2024.x) u-boot; it is currently implemented for the vendor u-boot but not for mainline. Not your fault, of course, but I guess that would help borrowing patches from openwrt.

@EvilOlaf
Copy link
Member Author

I think its not worth bothering with vendor on this board since all the interesting stuff should be available in both mainline uboot and Linux. The stuff mentioning it are mostly c&p relicts.

@igorpecovnik
Copy link
Member

@azagramac

image

Nobody is happy to do the hard work unless they are stealing absolutely everything. Not sure what advantages you see with Dietpi, but this is comparison from other angle:

https://docs.armbian.com/#key-advantages
armbian/configng#291

tl;dr;

  • we do everything around hardware interface
  • we provide OS without proprietary changes
  • we make build images possible
  • our system config is significantly more advanced

@EvilOlaf
Copy link
Member Author

EvilOlaf commented Jan 4, 2025

Source & credits https://patchwork.ozlabs.org/project/uboot/list/?series=438193
I still need to figure out how to convert a patch series from patchwork in a way so the build framework doesn't complain about headers and magic and whatever. So a few hundreds of header lines have been replaced with something generic.

Applies and builds fine now against current stable v2024.10
@EvilOlaf EvilOlaf marked this pull request as ready for review January 4, 2025 08:52
@EvilOlaf EvilOlaf requested a review from igorpecovnik as a code owner January 4, 2025 08:52
@EvilOlaf
Copy link
Member Author

EvilOlaf commented Jan 4, 2025

Still untested but well, screw it.
Patch header need rework to give proper credit....again

New image for testing: https://fi.mirror.armbian.de/.testing/Armbian-unofficial_25.02.0-trunk_Nanopi-r3s_bookworm_edge_6.13.0-rc5_minimal.img.xz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more
Development

Successfully merging this pull request may close these issues.

3 participants