sync disks before freeing loop device #7593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/small
Yeah, this is not the problem. I ran tests on CI infrastructure where several images are assembled in parallel. And it fails at once. I use this branch to test against: https://github.com/armbian/build/tree/test Tests:
|
igorpecovnik
added
Work in progress
swissiety
force-pushed
the
try2fix_freeing_loop_device
branch
from
c9cd1b4 to
6c401f2
Compare
swissiety
force-pushed
the
try2fix_freeing_loop_device
branch
from
6c401f2 to
18c6584
Compare
|
@igorpecovnik is there a way I can run the changes on the gh-actions infrastructure? |
|
I run it and it fails :( Let me give you rights to run this ... |
|
Once you accept invitation, there is a branch "test" in the https://github.com/armbian/build/ (you will be able to push there) And then just start this: and choose test branch:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
see comments in #7527
freeing loop devices seems unstable and fails freeing the loop device.
syncing disks helped at least addressing (loop) device problems in my last contribution (fix lvm,luks extension)
How Has This Been Tested?
shell ./compile.sh armbian-images build BOARD=uefi-x86 BRANCH=current BUILD_DESKTOP=yes BUILD_MINIMAL=no DESKTOP_APPGROUPS_SELECTED= DESKTOP_ENVIRONMENT=gnome DESKTOP_ENVIRONMENT_CONFIG_NAME=config_base ENABLE_EXTENSIONS=image-output-qcow2,v4l2loopback-dkms EXPERT=yes IMAGE_XZ_COMPRESSION_RATIO=1 KERNEL_CONFIGURE=no RELEASE=bookworm SHARE_LOG=yes SHOW_DEBUB=yesmultiple compile runs, could not reproduce getting an error anymore - but not confident that this was it.