Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hooks: introduce post_armbian_repo_customize_image and post_repo_customize_image #7719

Merged
merged 1 commit into from
Jan 19, 2025
Merged

hooks: introduce post_armbian_repo_customize_image and post_repo_customize_image #7719

merged 1 commit into from
Jan 19, 2025

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Jan 19, 2025 •
edited
Loading

  • post_repo_customize_image: runs after repos have been enabled
  • post_armbian_repo_customize_image: same, but only if Armbian repo is enabled
  • both run after apt update, so packages can be directly installed from repos

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Jan 19, 2025
@rpardini
Copy link
Member Author

Built a few images with this. Shouldn't break anything.
It does introduce an extra apt update during image build, but that's the price of consistency.

@rpardini rpardini marked this pull request as ready for review January 19, 2025 14:03
@rpardini rpardini requested a review from a team as a code owner January 19, 2025 14:03
@rpardini rpardini force-pushed the pr/hooks-introduce-postarmbianrepocustomizeimage-and-postrepocustomizeimage branch from 18ead93 to fb62e19 Compare January 19, 2025 14:06
@rpardini
hooks: introduce post_armbian_repo_customize_image and `post_repo_c…
db67c79 
…ustomize_image`

- `post_repo_customize_image`: runs after repos have been enabled
- `post_armbian_repo_customize_image`: same, but only if Armbian repo is enabled
- both run after apt update, so packages can be directly installed from repos
@rpardini rpardini force-pushed the pr/hooks-introduce-postarmbianrepocustomizeimage-and-postrepocustomizeimage branch from fb62e19 to db67c79 Compare January 19, 2025 14:09
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release and removed Needs review Seeking for review labels Jan 19, 2025
@igorpecovnik igorpecovnik mentioned this pull request Jan 19, 2025
Merged
6 tasks
@igorpecovnik igorpecovnik merged commit c469eeb into armbian:main Jan 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

Assignees
No one assigned
Labels
02 Milestone: First quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpardini @igorpecovnik